MyouProject/vmath
3
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

bug fix for some inputs into angle proc

Browse source
This commit is contained in:
lilkeet 2024-07-27 02:02:49 -05:00
parent c2aa04505b
commit aee0c310fe
1 changed files with 5 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
src/vmath.nim
View file

@ -1577,7 +1577,11 @@ proc angle*[T; S: GVec2[T]|GVec3[T]](a, b: S): T =
## Angle between 2 Vec2 or Vec3. ## Angle between 2 Vec2 or Vec3.
var dot = dot(a, b) var dot = dot(a, b)
dot = dot / (a.length * b.length) dot = dot / (a.length * b.length)
arccos(dot) # The cases of angle((1, 1), (-1, -1)) and its 3d counterpart
# angle((1, 1, 1), (-1, -1, -1)) result in NaN due to a domain defect going
# into the arcos proc: abs(x) > 1.0.
# Therefore, we must `clamp` here.
arccos(dot.clamp(-1.0, 1.0))
type type
Quat* = GVec4[float32] Quat* = GVec4[float32]