From 85780637fcf0af24771180ca36a3ff5cd770bf6b Mon Sep 17 00:00:00 2001
From: Ryan Oldenburg <ryan@guzba.com>
Date: Mon, 13 Dec 2021 02:25:58 -0600
Subject: [PATCH] mask yMin yMax better

---
 src/pixie/images.nim | 21 ++++++++++++---------
 1 file changed, 12 insertions(+), 9 deletions(-)

diff --git a/src/pixie/images.nim b/src/pixie/images.nim
index f791c64..00bc72a 100644
--- a/src/pixie/images.nim
+++ b/src/pixie/images.nim
@@ -768,17 +768,12 @@ proc drawUber(
   )
 
   # Determine where we should start and stop drawing in the y dimension
-  var yMin, yMax: int
-  if blendMode == bmMask:
-    yMin = 0
-    yMax = a.height
-  else:
+  var
     yMin = a.height
     yMax = 0
-    for segment in perimeter:
-      yMin = min(yMin, segment.at.y.floor.int)
-      yMax = max(yMax, segment.at.y.ceil.int)
-
+  for segment in perimeter:
+    yMin = min(yMin, segment.at.y.floor.int)
+    yMax = max(yMax, segment.at.y.ceil.int)
   yMin = yMin.clamp(0, a.height)
   yMax = yMax.clamp(0, a.height)
 
@@ -787,6 +782,10 @@ proc drawUber(
   else: # a is a Mask
     let masker = blendMode.masker()
 
+  if blendMode == bmMask:
+    if yMin > 0:
+      zeroMem(a.data[0].addr, 4 * yMin * a.width)
+
   for y in yMin ..< yMax:
     # Determine where we should start and stop drawing in the x dimension
     var
@@ -1007,6 +1006,10 @@ proc drawUber(
       if a.width - xMax > 0:
         zeroMem(a.data[a.dataIndex(xMax, y)].addr, 4 * (a.width - xMax))
 
+  if blendMode == bmMask:
+    if a.height - yMax > 0:
+      zeroMem(a.data[a.dataIndex(0, yMax)].addr, 4 * a.width * (a.height - yMax))
+
 proc draw*(
   a, b: Image, transform = mat3(), blendMode = bmNormal
 ) {.inline, raises: [PixieError].} =