Don't return a new image when filling paths.

src/pixie/fileformats/svg.nim

@@ -1,7 +1,7 @@
 ## Load and Save SVG files.
 
 import chroma, pixie/images, pixie/common, pixie/paths, vmath, xmlparser,
-  xmltree, strutils, strutils, bumpy
+  xmltree, strutils, strutils
 
 const svgSignature* = "<?xml"
 
@@ -111,13 +111,11 @@ proc draw(
       d = node.attr("d")
       ctx = decodeCtx(ctxStack[^1], node)
     if ctx.fill != ColorRGBA():
-      let (bounds, fillImg) = fillPathBounds(d, ctx.fill, ctx.transform)
+      img.fillPath(d, ctx.fill, ctx.transform)
-      img.draw(fillImg, bounds.xy)
     if ctx.stroke != ColorRGBA() and ctx.strokeWidth > 0:
-      let (bounds, strokeImg) = strokePathBounds(
+      img.strokePath(
         d, ctx.stroke, ctx.strokeWidth, ctx.transform
       )
-      img.draw(strokeImg, bounds.xy)
 
   of "line":
     let
@@ -219,13 +217,11 @@ proc draw(
 
     let d = $path
     if ctx.fill != ColorRGBA():
-      let (bounds, fillImg) = fillPathBounds(d, ctx.fill, ctx.transform)
+      img.fillPath(d, ctx.fill, ctx.transform)
-      img.draw(fillImg, bounds.xy)
     if ctx.stroke != ColorRGBA() and ctx.strokeWidth > 0:
-      let (bounds, strokeImg) = strokePathBounds(
+      img.strokePath(
         d, ctx.stroke, ctx.strokeWidth, ctx.transform
       )
-      img.draw(strokeImg, bounds.xy)
 
   else:
     raise newException(PixieError, "Unsupported SVG tag: " & node.tag & ".")

src/pixie/paths.nim

@@ -1,4 +1,4 @@
-import vmath, images, chroma, strutils, algorithm, common, bumpy
+import vmath, images, chroma, strutils, algorithm, common, bumpy, blends
 
 type
   WindingRule* = enum
@@ -594,15 +594,17 @@ proc computeBounds(polys: seq[seq[Vec2]]): Rect =
 {.push checks: off, stacktrace: off.}
 
 proc fillPolygons*(
+  image: Image,
   size: Vec2,
   polys: seq[seq[Vec2]],
   color: ColorRGBA,
   windingRule: WindingRule,
-  quality = 4,
+  blendMode: BlendMode = bmNormal,
-): Image =
+  quality = 4
-  const ep = 0.0001 * PI
+) =
 
-  result = newImage(size.x.int, size.y.int)
+  const ep = 0.0001 * PI
+  let mixer = blendMode.mixer()
 
   proc scanLineHits(
     polys: seq[seq[Vec2]],
@@ -630,12 +632,12 @@ proc fillPolygons*(
 
   var
     hits = newSeq[(float32, bool)]()
-    alphas = newSeq[float32](result.width)
+    alphas = newSeq[float32](image.width)
-  for y in 0 ..< result.height:
+  for y in 0 ..< image.height:
     # Reset alphas for this row.
     zeroMem(alphas[0].addr, alphas.len * 4)
 
-    # Do scanlines for this row.
+    # Do scan lines for this row.
     for m in 0 ..< quality:
       polys.scanLineHits(hits, size, y, float32(m) / float32(quality))
       if hits.len == 0:
@@ -643,7 +645,7 @@ proc fillPolygons*(
       var
         penFill = 0
         curHit = 0
-      for x in 0 ..< result.width:
+      for x in 0 ..< image.width:
         var penEdge: float32
         case windingRule
         of wrNonZero:
@@ -669,11 +671,13 @@ proc fillPolygons*(
           inc curHit
         alphas[x] += penEdge
 
-    for x in 0 ..< result.width:
+    for x in 0 ..< image.width:
       let a = clamp(abs(alphas[x]) / float32(quality), 0.0, 1.0)
-      var colorWithAlpha = color
+      if a > 0:
-      colorWithAlpha.a = uint8(a * 255.0)
+        var colorWithAlpha = color
-      result.setRgbaUnsafe(x, y, colorWithAlpha)
+        colorWithAlpha.a = uint8(a * 255.0)
+        let rgba = image.getRgbaUnsafe(x, y)
+        image.setRgbaUnsafe(x, y, mixer(rgba, colorWithAlpha))
 
 {.pop.}
 
@@ -698,8 +702,7 @@ proc fillPath*(
 ) =
   let
     polys = parseSomePath(path)
-    tmp = fillPolygons(image.wh, polys, color, windingRule)
+  image.fillPolygons(image.wh, polys, color, windingRule)
-  image.draw(tmp)
 
 proc fillPath*(
   image: Image,
@@ -712,8 +715,7 @@ proc fillPath*(
   for poly in polys.mitems:
     for i, p in poly.mpairs:
       poly[i] = p + pos
-  let tmp = fillPolygons(image.wh, polys, color, windingRule)
+  image.fillPolygons(image.wh, polys, color, windingRule)
-  image.draw(tmp)
 
 proc fillPath*(
   image: Image,
@@ -726,25 +728,7 @@ proc fillPath*(
   for poly in polys.mitems:
     for i, p in poly.mpairs:
       poly[i] = mat * p
-  let tmp = fillPolygons(image.wh, polys, color, windingRule)
+  image.fillPolygons(image.wh, polys, color, windingRule)
-  image.draw(tmp)
-
-proc fillPathBounds*(
-    path: SomePath,
-    color: ColorRGBA,
-    mat: Mat3,
-    windingRule = wrNonZero
-  ): (Rect, Image) =
-  var polys = parseSomePath(path)
-  for poly in polys.mitems:
-    for i, p in poly.mpairs:
-      poly[i] = mat * p
-  var bounds = computeBounds(polys)
-  for poly in polys.mitems:
-    for i, p in poly.mpairs:
-      poly[i] = p - bounds.xy
-  var image = fillPolygons(bounds.wh, polys, color, windingRule)
-  return (bounds, image)
 
 proc strokePath*(
   image: Image,
@@ -761,8 +745,7 @@ proc strokePath*(
     polys = parseSomePath(path)
     (strokeL, strokeR) = (strokeWidth/2, strokeWidth/2)
     polys2 = strokePolygons(polys, strokeL, strokeR)
-    tmp = fillPolygons(image.wh, polys2, color, windingRule)
+  image.fillPath(polys2, color, windingRule)
-  image.draw(tmp)
 
 proc strokePath*(
   image: Image,
@@ -787,8 +770,7 @@ proc strokePath*(
   for poly in polys2.mitems:
     for i, p in poly.mpairs:
       poly[i] = p + pos
-  let tmp = fillPolygons(image.wh, polys2, color, windingRule)
+  image.fillPolygons(image.wh, polys2, color, windingRule)
-  image.draw(tmp)
 
 proc strokePath*(
   image: Image,
@@ -804,20 +786,7 @@ proc strokePath*(
   for poly in polys2.mitems:
     for i, p in poly.mpairs:
       poly[i] = mat * p
-  let tmp = fillPolygons(image.wh, polys2, color, windingRule)
+  image.fillPolygons(image.wh, polys2, color, windingRule)
-  image.draw(tmp)
-
-proc strokePathBounds*(
-  path: SomePath,
-  color: ColorRGBA,
-  strokeWidth: float32,
-  mat: Mat3,
-  windingRule = wrNonZero
-): (Rect, Image) =
-  var polys = parseSomePath(path)
-  let (strokeL, strokeR) = (strokeWidth/2, strokeWidth/2)
-  var polys2 = strokePolygons(polys, strokeL, strokeR)
-  fillPathBounds(polys2, color, mat, windingRule)
 
 proc addPath*(path: Path, other: Path) =
   ## Adds a path to the current path.

tests/test_svg.nim

@@ -20,4 +20,4 @@ for file in files:
     gold = readImage(&"tests/images/svg/{file}.png")
 
   doAssert image.data == gold.data
-  # image.writeFile(&"{file}.png")
+  #image.writeFile(&"tests/images/svg/{file}.png")