From 31bd588b172c6bff9422d2220b62318b726742fe Mon Sep 17 00:00:00 2001
From: Ryan Oldenburg <ryan@guzba.com>
Date: Sun, 31 Jul 2022 19:28:05 -0500
Subject: [PATCH] simpler

---
 src/pixie/simd/sse2.nim | 18 ++++++------------
 tests/bench_fonts.nim   |  3 +--
 2 files changed, 7 insertions(+), 14 deletions(-)

diff --git a/src/pixie/simd/sse2.nim b/src/pixie/simd/sse2.nim
index df849dd..a5880ed 100644
--- a/src/pixie/simd/sse2.nim
+++ b/src/pixie/simd/sse2.nim
@@ -507,18 +507,10 @@ proc magnifyBy2Sse2*(image: Image, power = 1): Image {.simd.} =
         result.width * 4
       )
 
-proc applyCoverage*(rgbxVec, coverage: M128i): M128i {.inline.} =
-
-  proc unpackAlphaValues(v: M128i): M128i {.inline.} =
-    ## Unpack the first 32 bits into 4 rgba(0, 0, 0, value).
-    result = mm_unpacklo_epi8(mm_setzero_si128(), v)
-    result = mm_unpacklo_epi8(mm_setzero_si128(), result)
-
-  let
-    oddMask = mm_set1_epi16(0xff00)
-    div255 = mm_set1_epi16(0x8081)
-
-  var unpacked = unpackAlphaValues(coverage)
+template applyCoverage*(rgbxVec, coverage: M128i): M128i =
+  ## Unpack the first 4 coverage bytes.
+  var unpacked = mm_unpacklo_epi8(mm_setzero_si128(), coverage)
+  unpacked = mm_unpacklo_epi8(mm_setzero_si128(), unpacked)
   unpacked = mm_or_si128(unpacked, mm_srli_epi32(unpacked, 16))
 
   var
@@ -548,6 +540,8 @@ proc blendLineCoverageOverwriteSse2*(
     rgbxVec = mm_set1_epi32(cast[uint32](rgbx))
     vecZero = mm_setzero_si128()
     vec255 = mm_set1_epi8(255)
+    oddMask = mm_set1_epi16(0xff00)
+    div255 = mm_set1_epi16(0x8081)
   while i < len - 16:
     let
       coverage = mm_loadu_si128(coverages[i].addr)
diff --git a/tests/bench_fonts.nim b/tests/bench_fonts.nim
index 32bbc01..544ca12 100644
--- a/tests/bench_fonts.nim
+++ b/tests/bench_fonts.nim
@@ -5,8 +5,7 @@ const text = "Lorem ipsum dolor sit amet, consectetur adipiscing elit. Duis in q
 var font = readFont("tests/fonts/Roboto-Regular_1.ttf")
 font.size = 16
 
-let
-  image = newImage(500, 300)
+let image = newImage(500, 300)
 
 timeIt "typeset":
   discard font.typeset(text, bounds = vec2(image.width.float32, 0))