From 31a1fbb2a263411ea28eb5ea45d5903d97b4c703 Mon Sep 17 00:00:00 2001 From: Ryan Oldenburg Date: Sat, 30 Jul 2022 01:41:52 -0500 Subject: [PATCH] checkpoint --- experiments/bench_cairo_draw.nim | 18 +- src/pixie/blends.nim | 79 +---- src/pixie/images.nim | 461 ++++++++-------------------- src/pixie/simd/sse2.nim | 154 ++++++++-- tests/bench_images_draw_correct.nim | 33 -- tests/images/maskClearsOnDraw0.png | Bin 0 -> 332 bytes tests/images/maskClearsOnDraw1.png | Bin 0 -> 324 bytes tests/images/maskClearsOnDraw2.png | Bin 0 -> 318 bytes tests/images/maskClearsOnDraw3.png | Bin 0 -> 319 bytes tests/images/maskClearsOnDraw4.png | Bin 0 -> 324 bytes tests/test_images_draw.nim | 51 +++ 11 files changed, 310 insertions(+), 486 deletions(-) delete mode 100644 tests/bench_images_draw_correct.nim create mode 100644 tests/images/maskClearsOnDraw0.png create mode 100644 tests/images/maskClearsOnDraw1.png create mode 100644 tests/images/maskClearsOnDraw2.png create mode 100644 tests/images/maskClearsOnDraw3.png create mode 100644 tests/images/maskClearsOnDraw4.png diff --git a/experiments/bench_cairo_draw.nim b/experiments/bench_cairo_draw.nim index 6d159c6..e6431f8 100644 --- a/experiments/bench_cairo_draw.nim +++ b/experiments/bench_cairo_draw.nim @@ -1,4 +1,4 @@ -import benchy, cairo, pixie, pixie/blends, pixie/internal +import benchy, cairo, pixie block: let @@ -8,12 +8,6 @@ block: ctx = tmp.create() timeIt "cairo draw normal": - # ctx.setSourceRgba(0.5, 0.5, 0.5, 1) - # let operator = ctx.getOperator() - # ctx.setOperator(OperatorSource) - # ctx.paint() - # ctx.setOperator(operator) - ctx.setSource(backdrop, 0, 0) ctx.paint() ctx.setSource(source, 0, 0) @@ -29,7 +23,6 @@ block: tmp = newImage(1568, 940) timeIt "pixie draw normal": - # tmp.fill(rgbx(127, 127, 127, 255)) tmp.draw(backdrop) tmp.draw(source) @@ -42,7 +35,6 @@ block: tmp = newImage(1568, 940) timeIt "pixie draw overwrite": - # tmp.fill(rgbx(127, 127, 127, 255)) tmp.draw(backdrop, blendMode = OverwriteBlend) tmp.draw(source) @@ -56,17 +48,11 @@ block: ctx = tmp.create() timeIt "cairo draw mask": - ctx.setSourceRgba(1, 1, 1, 1) - let operator = ctx.getOperator() - ctx.setOperator(OperatorSource) - ctx.paint() - ctx.setOperator(operator) - ctx.setSource(backdrop, 0, 0) ctx.mask(source, 0, 0) tmp.flush() - # echo tmp.writeToPng("tmp_masked.png") + # tmp.writeToPng("tmp_masked.png") block: let diff --git a/src/pixie/blends.nim b/src/pixie/blends.nim index 484e9b3..ef473f1 100644 --- a/src/pixie/blends.nim +++ b/src/pixie/blends.nim @@ -1,6 +1,6 @@ ## Blending modes. -import chroma, common, simd, std/math +import chroma, common, std/math # See https://www.w3.org/TR/compositing-1/ # See https://www.khronos.org/registry/OpenGL/extensions/KHR/KHR_blend_equation_advanced.txt @@ -412,82 +412,5 @@ proc blender*(blendMode: BlendMode): Blender {.raises: [].} = of SubtractMaskBlend: subtractMaskBlender of ExcludeMaskBlend: excludeMaskBlender -when defined(amd64) and allowSimd: - type - BlenderSimd* = proc(blackdrop, source: M128i): M128i {.gcsafe, raises: [].} - ## Function signature returned by blenderSimd. - - proc blendNormalSimd*(backdrop, source: M128i): M128i {.inline.} = - let - alphaMask = mm_set1_epi32(cast[int32](0xff000000)) - oddMask = mm_set1_epi16(cast[int16](0xff00)) - div255 = mm_set1_epi16(cast[int16](0x8081)) - - var - sourceAlpha = mm_and_si128(source, alphaMask) - backdropEven = mm_slli_epi16(backdrop, 8) - backdropOdd = mm_and_si128(backdrop, oddMask) - - sourceAlpha = mm_or_si128(sourceAlpha, mm_srli_epi32(sourceAlpha, 16)) - - let k = mm_sub_epi32( - mm_set1_epi32(cast[int32]([0.uint8, 255, 0, 255])), - sourceAlpha - ) - - backdropEven = mm_mulhi_epu16(backdropEven, k) - backdropOdd = mm_mulhi_epu16(backdropOdd, k) - - backdropEven = mm_srli_epi16(mm_mulhi_epu16(backdropEven, div255), 7) - backdropOdd = mm_srli_epi16(mm_mulhi_epu16(backdropOdd, div255), 7) - - mm_add_epi8( - source, - mm_or_si128(backdropEven, mm_slli_epi16(backdropOdd, 8)) - ) - - proc blendMaskSimd*(backdrop, source: M128i): M128i {.inline.} = - let - alphaMask = mm_set1_epi32(cast[int32](0xff000000)) - oddMask = mm_set1_epi16(cast[int16](0xff00)) - div255 = mm_set1_epi16(cast[int16](0x8081)) - - var - sourceAlpha = mm_and_si128(source, alphaMask) - backdropEven = mm_slli_epi16(backdrop, 8) - backdropOdd = mm_and_si128(backdrop, oddMask) - - sourceAlpha = mm_or_si128(sourceAlpha, mm_srli_epi32(sourceAlpha, 16)) - - backdropEven = mm_mulhi_epu16(backdropEven, sourceAlpha) - backdropOdd = mm_mulhi_epu16(backdropOdd, sourceAlpha) - - backdropEven = mm_srli_epi16(mm_mulhi_epu16(backdropEven, div255), 7) - backdropOdd = mm_srli_epi16(mm_mulhi_epu16(backdropOdd, div255), 7) - - mm_or_si128(backdropEven, mm_slli_epi16(backdropOdd, 8)) - - proc normalSimdBlender(backdrop, source: M128i): M128i = - blendNormalSimd(backdrop, source) - - proc maskSimdBlender(backdrop, source: M128i): M128i = - blendMaskSimd(backdrop, source) - - proc overwriteSimdBlender(backdrop, source: M128i): M128i = - source - - proc blenderSimd*(blendMode: BlendMode): BlenderSimd {.raises: [PixieError].} = - ## Returns a blend function for a given blend mode with SIMD support. - case blendMode: - of NormalBlend: normalSimdBlender - of MaskBlend: maskSimdBlender - of OverwriteBlend: overwriteSimdBlender - else: - raise newException(PixieError, "No SIMD blender for " & $blendMode) - - proc hasSimdBlender*(blendMode: BlendMode): bool {.inline, raises: [].} = - ## Is there a blend function for a given blend mode with SIMD support? - blendMode in {NormalBlend, MaskBlend, OverwriteBlend} - when defined(release): {.pop.} diff --git a/src/pixie/images.nim b/src/pixie/images.nim index bcce99b..ddc1153 100644 --- a/src/pixie/images.nim +++ b/src/pixie/images.nim @@ -394,63 +394,11 @@ proc getRgbaSmooth*( else: topMix -proc blitLine(a, b: ptr UncheckedArray[ColorRGBX], len: int, blender: Blender) = - for i in 0 ..< len: - a[i] = blender(a[i], b[i]) - -proc blitLineNormal(a, b: ptr UncheckedArray[ColorRGBX], len: int) {.hasSimd.} = - for i in 0 ..< len: - a[i] = blendNormal(a[i], b[i]) - -proc blitLineOverwrite(a, b: ptr UncheckedArray[ColorRGBX], len: int) = - copyMem(a[0].addr, b[0].addr, len * 4) - -template getUncheckedArray(a: Image, x, y: int): ptr UncheckedArray[ColorRGBX] = - cast[ptr UncheckedArray[ColorRGBX]](a.data[a.dataIndex(x, y)].addr) - -proc blitRect( - a, b: Image, pos = ivec2(0, 0), blendMode = NormalBlend -) = - ## Blits one image onto another using integer position with color blending. - let - px = pos.x.int - py = pos.y.int - xStart = max(-px, 0) - yStart = max(-py, 0) - xEnd = min(b.width, a.width - px) - yEnd = min(b.height, a.height - py) - - case blendMode: - of NormalBlend: - for y in yStart ..< yEnd: - blitLineNormal( - a.getUncheckedArray(xStart + px, y + py), - b.getUncheckedArray(xStart, y), - xEnd - xStart - ) - of OverwriteBlend: - {.linearScanEnd.} - for y in yStart ..< yEnd: - blitLineOverwrite( - a.getUncheckedArray(xStart + px, y + py), - b.getUncheckedArray(xStart, y), - xEnd - xStart - ) - else: - let blender = blendMode.blender() - for y in yStart ..< yEnd: - blitLine( - a.getUncheckedArray(xStart + px, y + py), - b.getUncheckedArray(xStart, y), - xEnd - xStart, - blender - ) - proc drawCorrect( - a, b: Image, transform = mat3(), blendMode = NormalBlend, tiled = false -) {.raises: [PixieError].} = - ## Draws one image onto another using matrix with color blending. - + a, b: Image, transform = mat3(), blendMode: BlendMode, tiled: bool +) = + ## Draws one image onto another using a matrix transform and color blending. + ## This proc is not about performance, it should be as simple as possible. var inverseTransform = transform.inverse() # Compute movement vectors @@ -466,7 +414,131 @@ proc drawCorrect( dx /= 2 dy /= 2 filterBy2 /= 2 - inverseTransform = scale(vec2(1/2, 1/2)) * inverseTransform + inverseTransform = scale(vec2(0.5, 0.5)) * inverseTransform + + while filterBy2 <= 0.5: + b = b.magnifyBy2() + p *= 2 + dx *= 2 + dy *= 2 + filterBy2 *= 2 + inverseTransform = scale(vec2(2, 2)) * inverseTransform + + let blender = blendMode.blender() + for y in 0 ..< a.height: + for x in 0 ..< a.width: + let + samplePos = inverseTransform * vec2(x.float32 + h, y.float32 + h) + xFloat = samplePos.x - h + yFloat = samplePos.y - h + backdrop = a.unsafe[x, y] + sample = b.getRgbaSmooth(xFloat, yFloat, tiled) + blended = blender(backdrop, sample) + a.unsafe[x, y] = blended + +template getUncheckedArray( + image: Image, x, y: int +): ptr UncheckedArray[ColorRGBX] = + cast[ptr UncheckedArray[ColorRGBX]](image.data[image.dataIndex(x, y)].addr) + +proc blitLine(a, b: ptr UncheckedArray[ColorRGBX], len: int, blender: Blender) {.inline.} = + for i in 0 ..< len: + a[i] = blender(a[i], b[i]) + +proc blitLineOverwrite(a, b: ptr UncheckedArray[ColorRGBX], len: int) {.inline.} = + copyMem(a[0].addr, b[0].addr, len * 4) + +proc blitLineNormal(a, b: ptr UncheckedArray[ColorRGBX], len: int) {.hasSimd.} = + for i in 0 ..< len: + a[i] = blendNormal(a[i], b[i]) + +proc blitLineMask(a, b: ptr UncheckedArray[ColorRGBX], len: int) {.hasSimd.} = + for i in 0 ..< len: + a[i] = blendMask(a[i], b[i]) + +proc blitRect(a, b: Image, pos: Ivec2, blendMode: BlendMode) = + let + px = pos.x.int + py = pos.y.int + + if px >= a.width or px + b.width <= 0 or py >= a.height or py + b.height <= 0: + if blendMode == MaskBlend: + a.fill(rgbx(0, 0, 0, 0)) + return + + let + xStart = max(-px, 0) + yStart = max(-py, 0) + xEnd = min(b.width, a.width - px) + yEnd = min(b.height, a.height - py) + + case blendMode: + of NormalBlend: + for y in yStart ..< yEnd: + blitLineNormal( + a.getUncheckedArray(xStart + px, y + py), + b.getUncheckedArray(xStart, y), + xEnd - xStart + ) + of OverwriteBlend: + for y in yStart ..< yEnd: + blitLineOverwrite( + a.getUncheckedArray(xStart + px, y + py), + b.getUncheckedArray(xStart, y), + xEnd - xStart + ) + of MaskBlend: + {.linearScanEnd.} + if yStart + py > 0: + zeroMem(a.data[0].addr, (yStart + py) * a.width * 4) + for y in yStart ..< yEnd: + if xStart + px > 0: + zeroMem(a.data[a.dataIndex(0, y + py)].addr, (xStart + px) * 4) + blitLineMask( + a.getUncheckedArray(xStart + px, y + py), + b.getUncheckedArray(xStart, y), + xEnd - xStart + ) + if xEnd + px < a.width: + zeroMem( + a.data[a.dataIndex(xEnd + px, y + py)].addr, + (a.width - (xEnd + px)) * 4 + ) + if yEnd + py < a.height: + zeroMem( + a.data[a.dataIndex(0, yEnd + py)].addr, + (a.height - (yEnd + py)) * a.width * 4 + ) + else: + let blender = blendMode.blender() + for y in yStart ..< yEnd: + blitLine( + a.getUncheckedArray(xStart + px, y + py), + b.getUncheckedArray(xStart, y), + xEnd - xStart, + blender + ) + +proc draw*( + a, b: Image, transform = mat3(), blendMode = NormalBlend +) {.raises: [PixieError].} = + ## Draws one image onto another using a matrix transform and color blending. + var + inverseTransform = transform.inverse() + # Compute movement vectors + p = inverseTransform * vec2(0 + h, 0 + h) + dx = inverseTransform * vec2(1 + h, 0 + h) - p + dy = inverseTransform * vec2(0 + h, 1 + h) - p + filterBy2 = max(dx.length, dy.length) + b = b + + while filterBy2 >= 2.0: + b = b.minifyBy2() + p /= 2 + dx /= 2 + dy /= 2 + filterBy2 /= 2 + inverseTransform = scale(vec2(0.5, 0.5)) * inverseTransform while filterBy2 <= 0.5: b = b.magnifyBy2() @@ -485,277 +557,10 @@ proc drawCorrect( transform[2, 1].fractional == 0.0 ) - if not hasRotationOrScaling and not smooth and not tiled: - blitRect(a, b, ivec2(transform[2, 0].int32, transform[2, 1].int32), blendMode) - return - - let blender = blendMode.blender() - for y in 0 ..< a.height: - for x in 0 ..< a.width: - let - samplePos = inverseTransform * vec2(x.float32 + h, y.float32 + h) - xFloat = samplePos.x - h - yFloat = samplePos.y - h - backdrop = a.unsafe[x, y] - sample = b.getRgbaSmooth(xFloat, yFloat, tiled) - blended = blender(backdrop, sample) - a.unsafe[x, y] = blended - -proc drawUber( - a, b: Image, transform = mat3(), blendMode: BlendMode -) {.raises: [PixieError].} = - let - corners = [ - transform * vec2(0, 0), - transform * vec2(b.width.float32, 0), - transform * vec2(b.width.float32, b.height.float32), - transform * vec2(0, b.height.float32) - ] - perimeter = [ - segment(corners[0], corners[1]), - segment(corners[1], corners[2]), - segment(corners[2], corners[3]), - segment(corners[3], corners[0]) - ] - - var - inverseTransform = transform.inverse() - # Compute movement vectors - p = inverseTransform * vec2(0 + h, 0 + h) - dx = inverseTransform * vec2(1 + h, 0 + h) - p - dy = inverseTransform * vec2(0 + h, 1 + h) - p - filterBy2 = max(dx.length, dy.length) - b = b - - while filterBy2 >= 2.0: - b = b.minifyBy2() - p /= 2 - dx /= 2 - dy /= 2 - filterBy2 /= 2 - - while filterBy2 <= 0.5: - b = b.magnifyBy2() - p *= 2 - dx *= 2 - dy *= 2 - filterBy2 *= 2 - - let - hasRotationOrScaling = not(dx == vec2(1, 0) and dy == vec2(0, 1)) - smooth = not( - dx.length == 1.0 and - dy.length == 1.0 and - transform[2, 0].fractional == 0.0 and - transform[2, 1].fractional == 0.0 - ) - - # Determine where we should start and stop drawing in the y dimension - var - yMin = a.height - yMax = 0 - for segment in perimeter: - yMin = min(yMin, segment.at.y.floor.int) - yMax = max(yMax, segment.at.y.ceil.int) - yMin = yMin.clamp(0, a.height) - yMax = yMax.clamp(0, a.height) - - let blender = blendMode.blender() - - if blendMode == MaskBlend: - if yMin > 0: - zeroMem(a.data[0].addr, 4 * yMin * a.width) - - for y in yMin ..< yMax: - # Determine where we should start and stop drawing in the x dimension - var - xMin = a.width.float32 - xMax = 0.float32 - for yOffset in [0.float32, 1]: - let scanLine = Line( - a: vec2(-1000, y.float32 + yOffset), - b: vec2(1000, y.float32 + yOffset) - ) - for segment in perimeter: - var at: Vec2 - if scanline.intersects(segment, at) and segment.to != at: - xMin = min(xMin, at.x) - xMax = max(xMax, at.x) - - var xStart, xStop: int - if hasRotationOrScaling or smooth: - xStart = xMin.floor.int - xStop = xMax.ceil.int - else: - # Rotation of 360 degrees can cause knife-edge issues with floor and ceil - xStart = xMin.round().int - xStop = xMax.round().int - xStart = xStart.clamp(0, a.width) - xStop = xStop.clamp(0, a.width) - - # Skip this row if there is nothing in-bounds to draw - if xStart == a.width or xStop == 0: - continue - - if blendMode == MaskBlend: - if xStart > 0: - zeroMem(a.data[a.dataIndex(0, y)].addr, 4 * xStart) - - if smooth: - var srcPos = p + dx * xStart.float32 + dy * y.float32 - srcPos = vec2(srcPos.x - h, srcPos.y - h) - for x in xStart ..< xStop: - let - backdrop = a.unsafe[x, y] - sample = b.getRgbaSmooth(srcPos.x, srcPos.y) - blended = blender(backdrop, sample) - a.unsafe[x, y] = blended - srcPos += dx - - else: - var x = xStart - if not hasRotationOrScaling: - let - srcPos = p + dx * x.float32 + dy * y.float32 - sy = srcPos.y.int - var sx = srcPos.x.int - - if blendMode in {NormalBlend, OverwriteBlend} and - isOpaque(b.data, b.dataIndex(sx, sy), xStop - xStart): - copyMem( - a.data[a.dataIndex(x, y)].addr, - b.data[b.dataIndex(sx, sy)].addr, - (xStop - xStart) * 4 - ) - continue - - when defined(amd64) and allowSimd: - case blendMode: - of OverwriteBlend: - for _ in 0 ..< (xStop - xStart) div 16: - for q in [0, 4, 8, 12]: - let sourceVec = mm_loadu_si128(b.data[b.dataIndex(sx + q, sy)].addr) - mm_storeu_si128(a.data[a.dataIndex(x + q, y)].addr, sourceVec) - x += 16 - sx += 16 - of NormalBlend: - let vec255 = mm_set1_epi32(cast[int32](uint32.high)) - for _ in 0 ..< (xStop - xStart) div 16: - for q in [0, 4, 8, 12]: - let - sourceVec = mm_loadu_si128(b.data[b.dataIndex(sx + q, sy)].addr) - eqZer0 = mm_cmpeq_epi8(sourceVec, mm_setzero_si128()) - if mm_movemask_epi8(eqZer0) != 0xffff: - let eq255 = mm_cmpeq_epi8(sourceVec, vec255) - if (mm_movemask_epi8(eq255) and 0x8888) == 0x8888: - mm_storeu_si128(a.data[a.dataIndex(x + q, y)].addr, sourceVec) - else: - let - backdropIdx = a.dataIndex(x + q, y) - backdropVec = mm_loadu_si128(a.data[backdropIdx].addr) - mm_storeu_si128( - a.data[backdropIdx].addr, - blendNormalSimd(backdropVec, sourceVec) - ) - x += 16 - sx += 16 - of MaskBlend: - let vec255 = mm_set1_epi32(cast[int32](uint32.high)) - for _ in 0 ..< (xStop - xStart) div 16: - for q in [0, 4, 8, 12]: - let - sourceVec = mm_loadu_si128(b.data[b.dataIndex(sx + q, sy)].addr) - eqZer0 = mm_cmpeq_epi8(sourceVec, mm_setzero_si128()) - if mm_movemask_epi8(eqZer0) == 0xffff: - mm_storeu_si128( - a.data[a.dataIndex(x + q, y)].addr, - mm_setzero_si128() - ) - elif mm_movemask_epi8(mm_cmpeq_epi8(sourceVec, vec255)) != 0xffff: - let backdropVec = mm_loadu_si128(a.data[a.dataIndex(x + q, y)].addr) - mm_storeu_si128( - a.data[a.dataIndex(x + q, y)].addr, - blendMaskSimd(backdropVec, sourceVec) - ) - x += 16 - sx += 16 - else: - when type(a) is Image: - if blendMode.hasSimdBlender(): - let blenderSimd = blendMode.blenderSimd() - for _ in 0 ..< (xStop - xStart) div 16: - for q in [0, 4, 8, 12]: - let - backdrop = mm_loadu_si128(a.data[a.dataIndex(x + q, y)].addr) - source = mm_loadu_si128(b.data[b.dataIndex(sx + q, sy)].addr) - mm_storeu_si128( - a.data[a.dataIndex(x + q, y)].addr, - blenderSimd(backdrop, source) - ) - x += 16 - sx += 16 - - var srcPos = p + dx * x.float32 + dy * y.float32 - srcPos = vec2( - clamp(srcPos.x, 0, b.width.float32), - clamp(srcPos.y, 0, b.height.float32) - ) - - case blendMode: - of OverwriteBlend: - for x in x ..< xStop: - let - samplePos = ivec2((srcPos.x - h).int32, (srcPos.y - h).int32) - source = b.unsafe[samplePos.x, samplePos.y] - if source.a > 0: - a.unsafe[x, y] = source - srcPos += dx - of NormalBlend: - for x in x ..< xStop: - let - samplePos = ivec2((srcPos.x - h).int32, (srcPos.y - h).int32) - source = b.unsafe[samplePos.x, samplePos.y] - if source.a > 0: - if source.a == 255: - a.unsafe[x, y] = source - else: - let backdrop = a.unsafe[x, y] - a.unsafe[x, y] = blendNormal(backdrop, source) - srcPos += dx - of MaskBlend: - for x in x ..< xStop: - let - samplePos = ivec2((srcPos.x - h).int32, (srcPos.y - h).int32) - source = b.unsafe[samplePos.x, samplePos.y] - if source.a == 0: - a.unsafe[x, y] = rgbx(0, 0, 0, 0) - elif source.a != 255: - let backdrop = a.unsafe[x, y] - a.unsafe[x, y] = blendMask(backdrop, source) - srcPos += dx - else: - for x in x ..< xStop: - let - samplePos = ivec2((srcPos.x - h).int32, (srcPos.y - h).int32) - backdrop = a.unsafe[x, y] - sample = b.unsafe[samplePos.x, samplePos.y] - blended = blender(backdrop, sample) - a.unsafe[x, y] = blended - srcPos += dx - - if blendMode == MaskBlend: - if a.width - xStop > 0: - zeroMem(a.data[a.dataIndex(xStop, y)].addr, 4 * (a.width - xStop)) - - if blendMode == MaskBlend: - if a.height - yMax > 0: - zeroMem(a.data[a.dataIndex(0, yMax)].addr, 4 * a.width * (a.height - yMax)) - -proc draw*( - a, b: Image, transform = mat3(), blendMode = NormalBlend -) {.inline, raises: [PixieError].} = - ## Draws one image onto another using matrix with color blending. - a.drawUber(b, transform, blendMode) + if hasRotationOrScaling or smooth: + a.drawCorrect(b, inverseTransform.inverse(), blendMode, false) + else: + a.blitRect(b, ivec2(transform[2, 0].int32, transform[2, 1].int32), blendMode) proc drawTiled*( dst, src: Image, mat: Mat3, blendMode = NormalBlend diff --git a/src/pixie/simd/sse2.nim b/src/pixie/simd/sse2.nim index 062b972..04673f5 100644 --- a/src/pixie/simd/sse2.nim +++ b/src/pixie/simd/sse2.nim @@ -1,4 +1,4 @@ -import chroma, internal, nimsimd/sse2, pixie/common, vmath +import chroma, internal, nimsimd/sse2, pixie/blends, pixie/common, vmath when defined(release): {.push checks: off.} @@ -15,6 +15,56 @@ proc unpackAlphaValues*(v: M128i): M128i {.inline, raises: [].} = result = mm_unpacklo_epi8(mm_setzero_si128(), v) result = mm_unpacklo_epi8(mm_setzero_si128(), result) +proc blendNormalSimd*(backdrop, source: M128i): M128i {.inline.} = + let + alphaMask = mm_set1_epi32(cast[int32](0xff000000)) + oddMask = mm_set1_epi16(cast[int16](0xff00)) + div255 = mm_set1_epi16(cast[int16](0x8081)) + + var + sourceAlpha = mm_and_si128(source, alphaMask) + backdropEven = mm_slli_epi16(backdrop, 8) + backdropOdd = mm_and_si128(backdrop, oddMask) + + sourceAlpha = mm_or_si128(sourceAlpha, mm_srli_epi32(sourceAlpha, 16)) + + let k = mm_sub_epi32( + mm_set1_epi32(cast[int32]([0.uint8, 255, 0, 255])), + sourceAlpha + ) + + backdropEven = mm_mulhi_epu16(backdropEven, k) + backdropOdd = mm_mulhi_epu16(backdropOdd, k) + + backdropEven = mm_srli_epi16(mm_mulhi_epu16(backdropEven, div255), 7) + backdropOdd = mm_srli_epi16(mm_mulhi_epu16(backdropOdd, div255), 7) + + mm_add_epi8( + source, + mm_or_si128(backdropEven, mm_slli_epi16(backdropOdd, 8)) + ) + +proc blendMaskSimd*(backdrop, source: M128i): M128i {.inline.} = + let + alphaMask = mm_set1_epi32(cast[int32](0xff000000)) + oddMask = mm_set1_epi16(cast[int16](0xff00)) + div255 = mm_set1_epi16(cast[int16](0x8081)) + + var + sourceAlpha = mm_and_si128(source, alphaMask) + backdropEven = mm_slli_epi16(backdrop, 8) + backdropOdd = mm_and_si128(backdrop, oddMask) + + sourceAlpha = mm_or_si128(sourceAlpha, mm_srli_epi32(sourceAlpha, 16)) + + backdropEven = mm_mulhi_epu16(backdropEven, sourceAlpha) + backdropOdd = mm_mulhi_epu16(backdropOdd, sourceAlpha) + + backdropEven = mm_srli_epi16(mm_mulhi_epu16(backdropEven, div255), 7) + backdropOdd = mm_srli_epi16(mm_mulhi_epu16(backdropOdd, div255), 7) + + mm_or_si128(backdropEven, mm_slli_epi16(backdropOdd, 8)) + proc fillUnsafeSse2*( data: var seq[ColorRGBX], color: SomeColor, @@ -480,49 +530,91 @@ proc magnifyBy2Sse2*(image: Image, power = 1): Image {.simd.} = proc blitLineNormalSse2*( a, b: ptr UncheckedArray[ColorRGBX], len: int ) {.simd.} = + let + alphaMask = mm_set1_epi32(cast[int32](0xff000000)) + oddMask = mm_set1_epi16(cast[int16](0xff00)) + div255 = mm_set1_epi16(cast[int16](0x8081)) + vec255 = mm_set1_epi8(255) - # TODO align to 16 - - var i = 0 + var i: int while i < len - 4: - let source = mm_loadu_si128(b[i].addr) - backdrop = mm_loadu_si128(a[i].addr) - alphaMask = mm_set1_epi32(cast[int32](0xff000000)) - oddMask = mm_set1_epi16(cast[int16](0xff00)) - div255 = mm_set1_epi16(cast[int16](0x8081)) + eq255 = mm_cmpeq_epi8(source, vec255) + if (mm_movemask_epi8(eq255) and 0x00008888) == 0x00008888: # Opaque source + mm_storeu_si128(a[i].addr, source) + else: + let backdrop = mm_loadu_si128(a[i].addr) - var - sourceAlpha = mm_and_si128(source, alphaMask) - backdropEven = mm_slli_epi16(backdrop, 8) - backdropOdd = mm_and_si128(backdrop, oddMask) + var + sourceAlpha = mm_and_si128(source, alphaMask) + backdropEven = mm_slli_epi16(backdrop, 8) + backdropOdd = mm_and_si128(backdrop, oddMask) - sourceAlpha = mm_or_si128(sourceAlpha, mm_srli_epi32(sourceAlpha, 16)) + sourceAlpha = mm_or_si128(sourceAlpha, mm_srli_epi32(sourceAlpha, 16)) - let k = mm_sub_epi32( - mm_set1_epi32(cast[int32]([0.uint8, 255, 0, 255])), - sourceAlpha - ) + let multiplier = mm_sub_epi32( + mm_set1_epi32(cast[int32]([0.uint8, 255, 0, 255])), + sourceAlpha + ) - backdropEven = mm_mulhi_epu16(backdropEven, k) - backdropOdd = mm_mulhi_epu16(backdropOdd, k) + backdropEven = mm_mulhi_epu16(backdropEven, multiplier) + backdropOdd = mm_mulhi_epu16(backdropOdd, multiplier) + backdropEven = mm_srli_epi16(mm_mulhi_epu16(backdropEven, div255), 7) + backdropOdd = mm_srli_epi16(mm_mulhi_epu16(backdropOdd, div255), 7) - backdropEven = mm_srli_epi16(mm_mulhi_epu16(backdropEven, div255), 7) - backdropOdd = mm_srli_epi16(mm_mulhi_epu16(backdropOdd, div255), 7) + let added = mm_add_epi8( + source, + mm_or_si128(backdropEven, mm_slli_epi16(backdropOdd, 8)) + ) - let done = mm_add_epi8( - source, - mm_or_si128(backdropEven, mm_slli_epi16(backdropOdd, 8)) - ) - - mm_storeu_si128(a[i].addr, done) + mm_storeu_si128(a[i].addr, added) i += 4 - # TODO last 1-3 pixels - # for i in i ..< len: - # a[i] = blendNormal(a[i], b[i]) + for i in i ..< len: + a[i] = blendNormal(a[i], b[i]) + +proc blitLineMaskSse2*( + a, b: ptr UncheckedArray[ColorRGBX], len: int +) {.simd.} = + let + alphaMask = mm_set1_epi32(cast[int32](0xff000000)) + oddMask = mm_set1_epi16(cast[int16](0xff00)) + div255 = mm_set1_epi16(cast[int16](0x8081)) + vec255 = mm_set1_epi8(255) + + var i: int + while i < len - 4: + let + source = mm_loadu_si128(b[i].addr) + eq255 = mm_cmpeq_epi8(source, vec255) + if (mm_movemask_epi8(eq255) and 0x00008888) == 0x00008888: # Opaque source + discard + else: + let backdrop = mm_loadu_si128(a[i].addr) + + var + sourceAlpha = mm_and_si128(source, alphaMask) + backdropEven = mm_slli_epi16(backdrop, 8) + backdropOdd = mm_and_si128(backdrop, oddMask) + + sourceAlpha = mm_or_si128(sourceAlpha, mm_srli_epi32(sourceAlpha, 16)) + + backdropEven = mm_mulhi_epu16(backdropEven, sourceAlpha) + backdropOdd = mm_mulhi_epu16(backdropOdd, sourceAlpha) + backdropEven = mm_srli_epi16(mm_mulhi_epu16(backdropEven, div255), 7) + backdropOdd = mm_srli_epi16(mm_mulhi_epu16(backdropOdd, div255), 7) + + mm_storeu_si128( + a[i].addr, + mm_or_si128(backdropEven, mm_slli_epi16(backdropOdd, 8)) + ) + + i += 4 + + for i in i ..< len: + a[i] = blendMask(a[i], b[i]) when defined(release): {.pop.} diff --git a/tests/bench_images_draw_correct.nim b/tests/bench_images_draw_correct.nim deleted file mode 100644 index 93a27a0..0000000 --- a/tests/bench_images_draw_correct.nim +++ /dev/null @@ -1,33 +0,0 @@ -import benchy, pixie, pixie/images {.all.}, strformat, xrays - -block: - let - a = newImage(1000, 1000) - b = newImage(500, 500) - a.fill(rgba(255, 0, 0, 255)) - b.fill(rgba(0, 255, 0, 255)) - - a.drawCorrect(b, translate(vec2(250, 250)), blendMode = OverwriteBlend) - a.writeFile("tests/images/rotate0.png") - -block: - let - a = newImage(1000, 1000) - b = newImage(500, 500) - - timeIt "drawCorrect": - a.fill(rgba(255, 0, 0, 255)) - b.fill(rgba(0, 255, 0, 255)) - - a.drawCorrect(b, translate(vec2(250, 250)), blendMode = OverwriteBlend) - -block: - let - a = newImage(1000, 1000) - b = newImage(500, 500) - - timeIt "draw": - a.fill(rgba(255, 0, 0, 255)) - b.fill(rgba(0, 255, 0, 255)) - - a.draw(b, translate(vec2(250, 250)), blendMode = OverwriteBlend) diff --git a/tests/images/maskClearsOnDraw0.png b/tests/images/maskClearsOnDraw0.png new file mode 100644 index 0000000000000000000000000000000000000000..8654d56d49231e148c75af52ec330259c1e2e146 GIT binary patch literal 332 zcmeAS@N?(olHy`uVBq!ia0vp^DIm1$U z|I^>Iw*@7L``9?vf1b0K{a&+U4(mY?mS6!NM+0gyJ||4r%0@HOLC)=aw(I?`Gnx|cGJZ0a-w8OGplG-n7&;7|u6{1-oD!MuLn^XnhOaN@McByS0* U6rH@;02nR|p00i_>zopr0A$`$3jhEB literal 0 HcmV?d00001 diff --git a/tests/images/maskClearsOnDraw3.png b/tests/images/maskClearsOnDraw3.png new file mode 100644 index 0000000000000000000000000000000000000000..c1b353a6248dc96e4b6f78e37b76733146293dac GIT binary patch literal 319 zcmeAS@N?(olHy`uVBq!ia0vp^DIm